RUN-4569 Fix git-plugin POM developers for Maven Central#50
Merged
Conversation
publishing.gradle used project.ext.hasProperty('developers'), which checks the ExtraPropertiesExtension for a JavaBean property (always false) rather than the dynamic ext property, so the <developers> block was omitted. Maven Central requires developers, so closeSonatypeStagingRepository failed validation. Match the shared/salt-step form: if (project.ext.developers).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Maven POM metadata publication for the git-plugin by ensuring the <developers> section is emitted, addressing Maven Central validation failures during closeSonatypeStagingRepository.
Changes:
- Update the conditional check in the publishing POM configuration to correctly detect and include
ext.developers. - Ensure
generatePomFileForGit-pluginPublicationincludes the expected<developers>entries whenext.developersis configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<developers>section being omitted from the published POM, which causedcloseSonatypeStagingRepositoryto fail Central validation (400 - Deployment reached an unexpected status: Failed).gradle/publishing.gradleusedproject.ext.hasProperty('developers'), which checks theExtraPropertiesExtensionobject for a JavaBean property nameddevelopers(always false) instead of the dynamic ext property. Changed toif (project.ext.developers), matching the shared/salt-step publishing script.Verification
generatePomFileForGit-pluginPublicationnow emits<developers>withltamaster(Luis Toledo).Follow-up
2.0.1on the fixed commit to re-run the release + Central publish.